Checking for existing uProxy cloud server #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return Promise.reject({ | ||
| 'errcode': 'VM_DNE', | ||
| 'message': 'Droplet ' + name + ' doesnt exist' | ||
| return Promise.resolve({ |
There was a problem hiding this comment.
I think it's probably better to reject if the droplet doesn't exist; this will help simplify destroyServer_ and start. What do you think?
There was a problem hiding this comment.
Okay, I updated getDroplet_. Do you think this is better? Problem is that if getDroplet_ fails then start should continue but if it returns a droplet then start should throw an error. So start wasn't really simplified, but I do think it's better if getDroplet_ throws an error.
|
Nice! One comment. |
| * Finds a droplet with this name | ||
| * @param {String} droplet name, as a string | ||
| * @return {Promise.<Object>}, returns droplet if exists | ||
| * or undefined if it does not exist |
|
Better I think! A couple of suggestions then we'll be good to go. |
|
👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDroplet_()start()and returning unique error if server already existsthis.waitDigitalOceanActions_()indestroyServer()to determine when the DELETE action has been completed (so that we can then create a new server if necessary)This change is