Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tslint to the dist and travis builds, with a really simple config #355

Merged
merged 2 commits into from
Feb 8, 2016

Conversation

trevj
Copy link
Contributor

@trevj trevj commented Feb 5, 2016

Some end-of-week therapeutic build love...

Been playing around with tslint on a personal project. It's got some - IMO - glaring omissions, e.g. specifying an indent level (palantir/tslint#581), but many of the things are useful and it seems to be the only linting game in the TypeScript town.

This starts off small:

  • enforce single quotes throughout
  • add a lint build target, as part of the dist target
  • have Travis fail if lint fails (so it's effectively a presubmit)

Review on Reviewable

@trevj trevj force-pushed the trevj-tslint branch 2 times, most recently from d58b4d0 to 2bcadee Compare February 5, 2016 16:58
@jpevarnek
Copy link
Contributor

Awesome work! Glad to see this getting in and looking forward to when we add a few more rules (and get it into the uProxy repo)


Reviewed 33 of 33 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@jpevarnek
Copy link
Contributor

Have an explicit 👍!

trevj added a commit that referenced this pull request Feb 8, 2016
add tslint to the dist and travis builds, with a really simple config
@trevj trevj merged commit c97f22c into master Feb 8, 2016
@trevj trevj deleted the trevj-tslint branch March 7, 2016 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants