Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist candidate lines #353

Merged
merged 1 commit into from
Feb 2, 2016
Merged

whitelist candidate lines #353

merged 1 commit into from
Feb 2, 2016

Conversation

trevj
Copy link
Contributor

@trevj trevj commented Feb 2, 2016

Introduce a whitelist for candidate fields, the unexpected introduction of which has caused us some problems:
UWNetworksLab/uProxy-p2p#2167

Seems to fix the problem we've been seeing with Chrome 49+:

* chrome-stable chrome-beta chrome-canary firefox-stable firefox-beta firefox-canary
chrome-stable
chrome-beta
chrome-canary
firefox-stable
firefox-beta
firefox-canary

Review on Reviewable

@trevj trevj force-pushed the trevj-candidate-whitelist branch from be9a5e6 to cd20dec Compare February 2, 2016 20:11
@trevj trevj force-pushed the trevj-candidate-whitelist branch from cd20dec to de0a663 Compare February 2, 2016 20:12
@trevj
Copy link
Contributor Author

trevj commented Feb 2, 2016

Based on @bemasc's excellent diagnosis of the situation, BTW.

@bemasc
Copy link
Contributor

bemasc commented Feb 2, 2016

👍 Beautiful

trevj added a commit that referenced this pull request Feb 2, 2016
@trevj trevj merged commit da8734b into master Feb 2, 2016
@trevj trevj deleted the trevj-candidate-whitelist branch February 2, 2016 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants