Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue where inviteUser rejects #344

Merged
merged 4 commits into from
Jan 7, 2016
Merged

fix issue where inviteUser rejects #344

merged 4 commits into from
Jan 7, 2016

Conversation

trevj
Copy link
Contributor

@trevj trevj commented Jan 4, 2016

Fixes an issue by which inviteUser rejects unless the cloud instance has been added since last login.

Basically, we should check this.savedContacts_ for the presence of an invite with an ADMIN username and then reconnect. Oops, thanks for spotting!

Review on Reviewable

@trevj trevj changed the title fix issue where inviteUser rejects unless cloud instance has been added fix issue where inviteUser rejects Jan 4, 2016
@trevj trevj force-pushed the trevj-inviteuser-fix branch from 99955ff to 5ae812a Compare January 4, 2016 21:01
@lucyhe
Copy link
Contributor

lucyhe commented Jan 4, 2016

This is almost working as expected in my testing!
The situation I'm encountering:
Upon login, inviteUser is called to get an inviteUrl, but still exits early because it cant find the clientId in savedContacts. However, if I start proxying and then refresh the UI, inviteUser will work. (sendMessage calls reconnect_, and the correct entry is added to savedContacts.)

@trevj
Copy link
Contributor Author

trevj commented Jan 5, 2016

OK, I think inviteUser probably shouldn't be called at login -- let's chat later :-)

@trevj
Copy link
Contributor Author

trevj commented Jan 6, 2016

I've just been testing this with your pull request and inviting seems to work now, even if I haven't added the cloud instance since logging into cloud.

@lucyhe
Copy link
Contributor

lucyhe commented Jan 6, 2016

awesome, sounds good! 👍

trevj added a commit that referenced this pull request Jan 7, 2016
fix issue where inviteUser rejects
@trevj trevj merged commit 1871b19 into master Jan 7, 2016
@trevj trevj deleted the trevj-inviteuser-fix branch January 7, 2016 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants