Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserProfile should include status that indicates if a Cloud instance is owned by or shared with the local user. #342

Merged
merged 6 commits into from
Jan 6, 2016

Conversation

lucyhe
Copy link
Contributor

@lucyhe lucyhe commented Dec 18, 2015

Depends on: DefinitelyTyped/DefinitelyTyped#7263

uProxy will check the UserStatus to determine if a user should see a cloud instance in their Share tab (and therefore see a URL for sharing that cloud instance with others).

Review on Reviewable

@trevj trevj self-assigned this Jan 4, 2016
address: string,
username :string): freedom.Social.UserProfile {
var status = UserStatus.CLOUD_INSTANCE_SHARED_WITH_LOCAL;
if (username == ADMIN_USERNAME) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

===

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@trevj
Copy link
Contributor

trevj commented Jan 5, 2016

👍

lucyhe added a commit that referenced this pull request Jan 6, 2016
UserProfile should include status that indicates if a Cloud instance is owned by or shared with the local user.
@lucyhe lucyhe merged commit 4dc3ce9 into master Jan 6, 2016
@trevj trevj deleted the lucyhe-cloud_user_status branch June 17, 2016 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants