fixing fossil resource endpoint CFs for ReCiPe2016 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks I will review. Is this still in draft? |
|
I think it can be reviewed now. I am assuming that the failed tests are unrelated to ReCiPe? They seem to be caused by something in TRACI? |
|
thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of LCIAFormatter, endpoint characterization factors for fossil resource scarcity are being treated as midpoint-to-endpoint conversion factors, leading to wrong characterization factors at the endpoint "Damage to resource availability". This PR fixes this.
Context (from the original ReCiPe file):
@ErCollao