Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added change log details and DHIS2 info in settings config file #3

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Added change log details and DHIS2 info in settings config file #3

merged 2 commits into from
Jul 9, 2024

Conversation

ginic
Copy link
Contributor

@ginic ginic commented Jul 3, 2024 •
edited
Loading

These are just some minor clean ups to make the code a little easier to use and understand.

  • Removed all extra instructions left over from the python project template
  • DHIS2 connection info is read from a settings.ini config file
  • Filled in the Changelog with our project specific details
  • Updated data .gitignore
  • Configure unit tests to use request mocking
  • Added a configuration step for the DHIS2 server to make unit testing possible

@ginic ginic requested review from anjus1313 and YajieLi-Z and removed request for anjus1313 July 3, 2024 17:59
YajieLi-Z
YajieLi-Z reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@YajieLi-Z YajieLi-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! You've made our project more complete and secure, especially with the additions of requests_mock and the changelog updates. Everything looks good to me. Thanks for the improvements!

@rdziewietin
Copy link
Contributor

Looks good! Everything looks cleaned up, no changes needed. Thank you!

@ginic
Copy link
Contributor Author

ginic commented Jul 9, 2024

Thanks, @rdziewietin and @ByteYJ ! I'm going to merge this in.

@ginic ginic merged commit c8e8c9f into main Jul 9, 2024
5 checks passed
@ginic ginic deleted the remove_all_template_artifacts branch July 9, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YajieLi-Z YajieLi-Z YajieLi-Z left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ginic @rdziewietin @YajieLi-Z