Update eslint #1664
Merged
Update eslint #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklamberty
added
help wanted
kklamberty
added a commit
that referenced
this pull request
Jan 21, 2025
https://typescript-eslint.io/rules/no-require-imports/ There was a complaint from ESLint about the use of require in the `cypress.config.ts` file. There is a Cypress plugin for ESLint https://github.com/cypress-io/eslint-plugin-cypress and this approach to adding it to the `.eslintrc.json` is suggested in the history of the project. The project claims you need to be using ESLint 9 or greater, which we probably should look into, and it might mean that this plugin would need to be updated manually in that migration process. I have a PR for that migration as well: #1664
NicMcPhee
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
I think the .mjs is just a a JS module file, taking advantage of some newer JS features. It basically just moved the rules in .eslintrc.json into that JS module file.
The ... is similar to the spread operator in Python if you've used that. I don't know if I've ever used it in JS/TS, but we could potentially file it useful in places?
It would probably make sense to sit down and go over (and document) the contents of this file to make it easier to understand and maintain downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint 8 has reached end of life, and it looks like it's important to update this to version 9 or more. Luckily, @NicMcPhee already did some work to modernize our eslint configuration, so I was able to basically just follow the migration guide here: https://eslint.org/docs/latest/use/migrate-to-9.0.0
However, I'm still not sure I have completed this task, nor do I know how to check. I think that the name of the file generated ending in .mjs might mean I need to do something more (at least rename that file to just .js at the end?) but I don't know. When I do rename the file to end in just
.jsrather than.mjs, I get some additional warning:I don't know if that warning tells me more (like, hey, you're actually linting now), or if leaving it as mjs is preferred. Also, the file contains more
...than I would have expected. I don't know what those mean. I see references about it being the spread operator and about it being used to indicate things that are overwritten. The overwriting idea makes some sense in this context... like you will be given some default setting, and instead you will use this. But, I'd still like to have input from others on this PR in case I've done something wildly incorrect or I've somehow turned off linting. Any thoughts?I installed a node deprecation checker (
npm install npm-deprecated-check) and usedndc currentto check the installation, and that made it seem like I have maybe at least succeeded in removing the deprecated eslint.