Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node from 22-alpine to 23-alpine in /client #1616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2024

Bumps node from 22-alpine to 23-alpine.

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
node [>= 18.pre.alpine.a, < 19]
node [>= 21.pre.alpine.a, < 22]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Oct 21, 2024
@kklamberty
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/docker/client/node-23-alpine branch from 2a2607a to 8f6ddd8 Compare January 21, 2025 02:19
@kklamberty
Copy link
Member

I was trying to decide if an odd numbered Node was a good idea because I had heard somewhere that it's not a great plan, and I wasn't sure if that applied to things for docker or not. It looks like maybe there are people with opinions who say it's not a great plan to use odd numbered Node stuff, even for Docker. But, I also saw some cautionary messages about using Alpine versus slim. Including here for reference.

Be careful with "Alpine" variant
Even though "alpine" variant is 30% thiner than "slim" variant, avoid using it for mission-critical NodeJS applications.

Alpine is considered experimental and not officially supported target platform for Node.JS.
"Slim" variant uses Debian, while "Alpine" variant uses Alpine Linux.
Alpine uses "Musl" C library instead of widespread GNU C Library (glibc) which leads to compatibility issue and unexpected behaviors or bugs.

https://dev.to/ptuladhar3/avoid-using-bloated-nodejs-docker-image-in-production-3doc

@kklamberty
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/docker/client/node-23-alpine branch from 8f6ddd8 to f04b1dd Compare January 29, 2025 06:48
@kklamberty
Copy link
Member

@dependabot rebase

Bumps node from 22-alpine to 23-alpine.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/docker/client/node-23-alpine branch from f04b1dd to a11020d Compare February 5, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant