Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing code complexity pattern #438

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aaronrussellHO
Copy link
Contributor

Is this pull request a content or a code change? (Please fill in the relevant section and delete the other)

Code change

I can confirm:

Accessibility considerations

or

  • This change might impact accessibility, automated aXe tests cover the impact

or

  • This change might impact accessibility and is not covered by automated aXe tests - manual testing has been performed
    (If the change might impact accessibility then please add some further information here)

Content change

I can confirm:

  • Content does not include any code or configuration changes (excluding frontmatter information)
  • Content meets the content standards
    e.g. Writing a principle and Writing a standard
  • Content is suitable to open source, i.e.:
    • Content does not relate to unreleased gov policy
    • Content does not refer to anti-fraud mechanisms
    • Content does not include sensitive business logic
  • Last updated date for content is correct

@aaronrussellHO aaronrussellHO requested a review from a team as a code owner July 23, 2024 08:39

#### Splitting files and functions

Keeping code a succinct, easy to manage files and functions makes it easier to maintain with simpler functions and allows for further reuse.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Keeping code a succinct, easy to manage files and functions makes it easier to maintain with simpler functions and allows for further reuse.
Keeping code succinct, easy to manage files and functions makes it easier to maintain with simpler functions and allows for further reuse.


## Considerations

- Teams should have agree owns standards for code, set some rules and document them. Following this, the same standards can be used across code reviews, rules set in tools (for instance, setting a high complexity allowed, allowing high LOC's etc.).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Teams should have agree owns standards for code, set some rules and document them. Following this, the same standards can be used across code reviews, rules set in tools (for instance, setting a high complexity allowed, allowing high LOC's etc.).
- Teams should agree their own standards for code, set some rules and document them. Following this, the same standards can be used across code reviews, rules set in tools (for instance, setting a high complexity allowed, allowing high LOC's etc.).

@aaronrussellHO aaronrussellHO changed the title WIP: Reducing code complexity pattern Reducing code complexity pattern Aug 6, 2024
@mikewaldnerscottwork mikewaldnerscottwork self-assigned this Oct 28, 2024
Copy link

@mikewaldnerscottwork mikewaldnerscottwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality of wording improvements - minor life quality change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants