Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated node-sass to 3.7.0 #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

joefitter
Copy link
Contributor

No description provided.

@daniel-ac-martin
Copy link
Collaborator

I think you might need to rebase this off your other branch and then make a PR on your PR because you like PRs.

I could be wrong though. We shall see.

@daniel-ac-martin
Copy link
Collaborator

The reason I say that is that I don't think HOF v6 will work with a node-sass newer than v3.4.

@JoeChapman
Copy link
Contributor

@daniel-ac-martin
Copy link
Collaborator

@JoeChapman: That's not why this PR is failing though. It due to a bug that I fixed in hmpo-frontend-toolkit that HOF v6 doesn't have.

If it is rebased off of the other PRs branch I suspect it will work.

@daniel-ac-martin
Copy link
Collaborator

Then @joefitter can make a new PR. Which is a PR on his PR and it will be like Inception.

@JoeChapman
Copy link
Contributor

v6, or just v6?

@daniel-ac-martin
Copy link
Collaborator

@JoeChapman: You've lost me.

The bug was fixed between HOF v6 and HOF v7. So you need at least HOF v7 to use node-sass >= 3.5.

@daniel-ac-martin
Copy link
Collaborator

BTW, if people don't want to worry about PRs on PRs then maybe just update node-sass in the other PR and be done with it?

@daniel-ac-martin
Copy link
Collaborator

@joefitter: Can we close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants