Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DTFS2-7741): fixed deal cancellation portal activities #4237

Draft
wants to merge 4 commits into
base: release-2.7
Choose a base branch
from

Conversation

abhi-markan
Copy link
Contributor

Introduction ✏️

When canceling a deal on TFM, the portal activity does not accurately depict the different stages of deal cancellation for effective date in past, present and future.

Resolution ✔️

  • Updated the NJK macro to effectively represent the fianl stage of the deal cancellation.
    • If effective date is in past or present it will be set to Cancelled.
    • If it is in future it will be set to Pending cancellation.
    • Once actioned via CRON job it will be set to Cancelled.

image

Miscellaneous ➕

  • Improved documentation.
  • Lint fixes.

@abhi-markan abhi-markan self-assigned this Feb 24, 2025
@abhi-markan abhi-markan marked this pull request as draft February 24, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant