Sync join and sync leave documentation #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tianyuan129 anything I should add? I know other protocol spec documentation is longer, but I'm not sure what specifically to explain. |
|
Don't these new documents have to be referenced from the index or some other document? I believe sphinx raises a warning otherwise (and also, how does the reader discover their existence?) |
|
Thanks Davide--you are completely correct. I have now linked them into |
tianyuan129
reviewed
Apr 12, 2024
tianyuan129
approved these changes
Apr 13, 2024
|
I think it's good to go. Thank you so much for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tianyuan129