Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

firewalld var name prefix #19

Merged
merged 4 commits into from
Jan 5, 2024
Merged

firewalld var name prefix #19

merged 4 commits into from
Jan 5, 2024

Conversation

drmatthews
Copy link
Contributor

@drmatthews drmatthews commented Jan 4, 2024 •
edited
Loading

Changes:

  • Update variable names for the firewalld role in the molecule tests
  • Update some details in galaxy.yml

After UCL-MIRSG/ansible-collection-infra#35 is merged I propose creating a new release of the mirsg.infrastructure collection (1.3.0) and pinning the version number in meta/requirements.yml in this PR.

@drmatthews drmatthews requested a review from p-j-smith January 4, 2024 17:56
p-j-smith
p-j-smith approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for fixing the galaxy file

@drmatthews drmatthews merged commit 38d48ce into main Jan 5, 2024
@drmatthews drmatthews deleted the drmatthews-firewalld-var-name-prefix branch January 5, 2024 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@p-j-smith p-j-smith p-j-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drmatthews @p-j-smith