Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine ansible-collection-infra & UCLMedicalImagingEnv configs #166

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

paddyroddy
Copy link
Member

In order to reduce repetition and have a single source of truth, I have looked through all repos and found the only ansible-collection-infra and UCLMedicalImagingEnv have custom configs that make sense to reuse — for example, combining XNAT plugins. This PR is preliminary work before I investigate minimumReleaseAge.

Once this is merged, I will raise PRs in the respective repos to simplify their configs.

@paddyroddy paddyroddy added the renovate Renovate config label Feb 26, 2025
@paddyroddy paddyroddy requested a review from a team February 26, 2025 11:00
@paddyroddy paddyroddy self-assigned this Feb 26, 2025
Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to remove some duplication!

Is it worth putting these changes into a separate config in this repo (e.g. xnat-config.json5) that the collection and and UCLMedicalImagingEnv can use, so that other repos don't have these unnecessary datasources and package rules?

I don't feel strongly about this though. Happy with whatever you decide

@paddyroddy
Copy link
Member Author

Is it worth putting these changes into a separate config in this repo (e.g. xnat-config.json5) that the collection and and UCLMedicalImagingEnv can use, so that other repos don't have these unnecessary datasources and package rules?

My thought is that we would always want those XNAT plugins combined etc., so I'd be inclined to disagree. Any thoughts @drmatthews @HChughtai?

@p-j-smith
Copy link
Contributor

My thought is that we would always want those XNAT plugins combined etc.,

Yep that's true, although I was thinking more about repos that don't have XNAT and these plugins as dependencies. Not super important though, happy for it to stay in the default config

@paddyroddy
Copy link
Member Author

Yep that's true, although I was thinking more about repos that don't have XNAT and these plugins as dependencies. Not super important though, happy for it to stay in the default config

Essentially, nothing would happen. It would find dependencies, check if they're in a group, do something. In this case it wouldn't find anything and then move on.

@paddyroddy
Copy link
Member Author

Have discussed with Haroon and these are sufficiently general that I am going to merge.

@paddyroddy paddyroddy merged commit 703dc1b into main Feb 26, 2025
2 checks passed
@paddyroddy paddyroddy deleted the combine-configs branch February 26, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renovate Renovate config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants