Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate morsefreq #30

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

henry2004y
Copy link
Contributor

Tries to handle #29. I kept the version originally in createWavelets.jl since that is the one which is included last. Please check if this is proper.

I also used the intrinsic isempty method for checking empty list.

@dsweber2
Copy link
Member

I'm not actually sure, as both of those were written by @wchak. I'm assuming the one doing the overwriting is correct, but let's wait for him to check it.

@wchak
Copy link
Contributor

wchak commented Nov 15, 2021

Hi, thanks for pointing out the issue. I will remove a function from either the Julia script and edit a line in createWavelets.jl to make the results consistent.

@dsweber2 dsweber2 mentioned this pull request Nov 15, 2021
@dsweber2 dsweber2 merged commit 579a908 into UCD4IDS:master Nov 15, 2021
@dsweber2
Copy link
Member

that's what this pull request is for, I just needed the confirmation on the intended version.

@henry2004y henry2004y deleted the duplicate_morsefreq branch November 16, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants