DataFavorites #827

dependency injection fix

src/Plugin/search_api/processor/DataFavorites.php

@@ -6,6 +6,8 @@
 use Drupal\search_api\Item\ItemInterface;
 use Drupal\search_api\Processor\ProcessorPluginBase;
 use Drupal\search_api\Processor\ProcessorProperty;
+use Symfony\Component\DependencyInjection\ContainerInterface;
+use Drupal\flag\FlagServiceInterface;
 
 /**
  * Search API Processor for indexing data reports favorites.
@@ -23,6 +25,42 @@
  */
 class DataFavorites extends ProcessorPluginBase {
 
+  /**
+   * The flag service.
+   *
+   * @var \Drupal\flag\FlagServiceInterface
+   */
+  protected $flagService;
+
+  /**
+   * Constructs a DataFavorites object.
+   *
+   * @param array $configuration
+   *   A configuration array containing information about the plugin instance.
+   * @param string $plugin_id
+   *   The plugin ID for the plugin instance.
+   * @param mixed $plugin_definition
+   *   The plugin implementation definition.
+   * @param \Drupal\flag\FlagServiceInterface $flag_service
+   *   The flag service.
+   */
+  public function __construct(array $configuration, $plugin_id, $plugin_definition, FlagServiceInterface $flag_service) {
+    parent::__construct($configuration, $plugin_id, $plugin_definition);
+    $this->flagService = $flag_service;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
+    return new static(
+      $configuration,
+      $plugin_id,
+      $plugin_definition,
+      $container->get('flag')
+    );
+  }
+
   /**
    * {@inheritdoc}
    */
@@ -48,7 +86,7 @@ public function getPropertyDefinitions(?DatasourceInterface $datasource = NULL)
   public function addFieldValues(ItemInterface $item) {
     $entity = $item->getOriginalObject()->getValue();
 
-    $flag = \Drupal::service('flag')->getFlaggingUsers($entity);
+    $flag = $this->flagService->getFlaggingUsers($entity);
 
     $flag_uids = array_keys($flag);