Added db.py file template #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UB-AICLUB
reviewed
Sep 21, 2024
| collection = client.get_or_create_collection(name=collection_name) | ||
|
|
||
| # Assuming each item needs a unique ID, we're using the text as the ID here | ||
| # In a real-world scenario, you might want to use a more robust ID generation method |
There was a problem hiding this comment.
shouldn't we just go ahead with uuid.uuid4() to get a random id?
There was a problem hiding this comment.
we can go with random id, i will make the changes
apurvabanka
reviewed
Sep 23, 2024
| import chromadb | ||
| from chromadb.config import Settings | ||
|
|
||
| def get_connection(): |
There was a problem hiding this comment.
Can we create a class instead, with all the initialisations in the init function. This will eliminate need to call get_connection for creating the function. We can then create the CRUD operations inside the class.
@UB-AICLUB Thoughts?
There was a problem hiding this comment.
yeah we could go with a class but i guess lets not make him do this over again this works na so lets go ahead with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the template db.py for chromaDB