Skip to content

Commit

Permalink
Slim down refresh and resize events
Browse files Browse the repository at this point in the history
  • Loading branch information
Tyriar committed Aug 19, 2017
1 parent e848d6a commit 8fdedd4
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions fixtures/typings-test/typings-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ namespace methods_core {
t.on('keypress', () => {});
t.on('keypress', (event: KeyboardEvent) => console.log(event));
t.on('refresh', () => {});
t.on('refresh', (data: {element: HTMLElement, start: number, end: number}) => console.log(data));
t.on('refresh', (data: {start: number, end: number}) => console.log(data));
t.on('resize', () => {});
t.on('resize', (data: {terminal: Terminal, cols: number, rows: number}) => console.log(data));
t.on('resize', (data: {cols: number, rows: number}) => console.log(data));
t.on('scroll', () => {});
t.on('scroll', (ydisp: number) => console.log(ydisp));
t.on('title', () => {});
Expand Down
2 changes: 1 addition & 1 deletion src/Renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ export class Renderer {
this._terminal.element.appendChild(this._terminal.rowContainer);
}

this._terminal.emit('refresh', {element: this._terminal.element, start: start, end: end});
this._terminal.emit('refresh', {start, end});
};

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Terminal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1944,7 +1944,7 @@ export class Terminal extends EventEmitter implements ITerminal, IInputHandlingT
this.refresh(0, this.rows - 1);

this.geometry = [this.cols, this.rows];
this.emit('resize', {terminal: this, cols: x, rows: y});
this.emit('resize', {cols: x, rows: y});
}

/**
Expand Down
4 changes: 2 additions & 2 deletions typings/xterm.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,13 @@ declare module 'xterm' {
* @param type The type of the event.
* @param listener The listener.
*/
on(type: 'refresh', listener: (data?: {element: HTMLElement, start: number, end: number}) => void): void;
on(type: 'refresh', listener: (data?: {start: number, end: number}) => void): void;
/**
* Registers an event listener.
* @param type The type of the event.
* @param listener The listener.
*/
on(type: 'resize', listener: (data?: {terminal: Terminal, cols: number, rows: number}) => void): void;
on(type: 'resize', listener: (data?: {cols: number, rows: number}) => void): void;
/**
* Registers an event listener.
* @param type The type of the event.
Expand Down

0 comments on commit 8fdedd4

Please sign in to comment.