Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(REACH-374): Prepare live embed code initializer #587

Merged
merged 7 commits into from
Jun 7, 2023
Merged

feat(REACH-374): Prepare live embed code initializer #587

merged 7 commits into from
Jun 7, 2023

Conversation

gierlas
Copy link
Contributor

@gierlas gierlas commented May 23, 2023 •
edited by jira bot
Loading

What

JIRA: REACH-374

Added and single embed code initializer that's ran before all other initializers.

@gierlas gierlas requested a review from a team May 23, 2023 14:53
@gierlas gierlas marked this pull request as draft May 23, 2023 14:56
@typeform-ops-gha
Copy link

[BOT] Preview available with hash e20cb585689d22d715e6073f02fea0b052ab0507 here.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash fd965b44336b3ddc5dc04a3fd7d1f86eab48ec9a here.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash 83168685e80c264c7c46a83ced70a9841675f924 here.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash 192b72045064576ae8e48b18949742392b6cc691 here.

@gierlas gierlas marked this pull request as ready for review May 24, 2023 09:57
@typeform-ops-gha
Copy link

[BOT] Preview available with hash cc384c770d4dd06905ae7b5eb13ad2b309c7bce3 here.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash 325d23840a7833e315eac694ecec42ac312a0db0 here.

@mathio mathio force-pushed the feat/REACH-374-single-code-embed branch from f8cb334 to 6ca4b64 Compare May 31, 2023 06:35
@typeform-ops-gha
Copy link

[BOT] Preview available with hash 60dd8e9b3fe91c8101fa2274f99d717e653c36d6 here.

mathio
mathio suggested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@mathio mathio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until we decide on final naming of the feature.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash 635fbeaad100afa34295d25c02c3209d4fa77bd5 here.

@mathio mathio changed the title feat(REACH-374): Prepare single embed initializer feat(REACH-374): Prepare live embed code initializer Jun 5, 2023
@gierlas gierlas merged commit 6c7ff53 into main Jun 7, 2023
@gierlas gierlas deleted the feat/REACH-374-single-code-embed branch June 7, 2023 08:34
typeform-ops-gha pushed a commit that referenced this pull request Jun 7, 2023
@semantic-release-bot
chore(release): 2.12.0 [skip ci]
76b694b 
# [@typeform/embed-v2.12.0](https://github.com/Typeform/embed/compare/@typeform/embed-v2.11.0...@typeform/embed-v2.12.0) (2023-06-07)

### Features

* **REACH-374:** Prepare live embed code initializer ([#587](#587)) ([6c7ff53](6c7ff53))
@typeform-ops-gha
Copy link

🎉 This PR is included in version @typeform/embed-v2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumpo mumpo mumpo left review comments

@mathio mathio mathio approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gierlas @typeform-ops-gha @mathio @mumpo