Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TU-21474): Remove overflow on widget close #677

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(TU-21474): Remove overflow on widget close #677

merged 1 commit into from
Jan 7, 2025

Conversation

joycevherck
Copy link
Contributor

Resolves #673

This behaviour is already existing for the Popup and Slider embeds so bringing this over to the Widget when the fullScreen option is enabled.

@joycevherck joycevherck requested a review from a team as a code owner January 6, 2025 09:30
@tf-security
Copy link
Contributor

tf-security commented Jan 6, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)

@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Jan 6, 2025

🥷 Code experts: no user matched threshold 10

See details

packages/demo-nextjs/next-env.d.ts

Knowledge based on git-blame:

packages/embed/src/factories/create-widget/create-widget.ts

Knowledge based on git-blame:

To learn more about /:\ gitStream - Visit our Docs

@typeform-ops-gha
Copy link

[BOT] Preview available with hash be7b798faf3916ae225c39d649d2fbb8c0d8d7ac here.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joycevherck joycevherck merged commit ee4ddf6 into main Jan 7, 2025
16 checks passed
@joycevherck joycevherck deleted the TU-21474/embed-unmount branch January 7, 2025 10:39
typeform-ops-gha pushed a commit that referenced this pull request Jan 8, 2025
@semantic-release-bot
chore(release): 5.3.0 [skip ci]
d41fdc4 
# [@typeform/embed-v5.3.0](https://github.com/Typeform/embed/compare/@typeform/embed-v5.2.0...@typeform/embed-v5.3.0) (2025-01-08)

### Bug Fixes

* **TU-21474:** Remove overflow on widget close ([#677](#677)) ([ee4ddf6](ee4ddf6))

### Features

* **TU-20040:** Add `isClosed` to `onReady` callback payload ([#670](#670)) ([f263f9e](f263f9e)), closes [#647](#647)
@typeform-ops-gha
Copy link

🎉 This PR is included in version @typeform/embed-v5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robespmun robespmun robespmun approved these changes

Assignees
No one assigned
Labels
1 min review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fullScreen adds overflow: hidden to the body tag, which is not removed on page navigation
4 participants
@joycevherck @tf-security @typeform-ops-gha @robespmun