Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullScreen adds overflow: hidden to the body tag, which is not removed on page navigation #673

Closed
steve-marmalade opened this issue Dec 16, 2024 · 4 comments · Fixed by #677
Assignees
Labels
bug Something isn't working next released

Comments

@steve-marmalade
Copy link

When setting <Widget fullScreen={true} />, this causes overflow:hidden to be assigned to the <body> tag.

Since this setting is not removed when doing a client-side navigation (e.g. using the next.js <Link> or router.push APIs), it has the effect of making it so you can't scroll on the website after starting the quiz.

My hope is that this library can find a way to manage fullScreen mode without updating styles on the <body> tag (or anywhere in the document that's outside of the Widget element)

@github-actions github-actions bot added new Flag for new issues before someone replies next labels Dec 16, 2024
@joycevherck
Copy link
Contributor

Thanks for raising! My initial thinking is to make sure that the overflow styles get removed when the widget is unmounted. I've added a ticket into our team's backlog for prioritisation but just to manage expectations, we're nearing code freeze for the winter break so this likely won't be addressed until the new year.

@joycevherck joycevherck self-assigned this Jan 6, 2025
@joycevherck joycevherck added bug Something isn't working and removed new Flag for new issues before someone replies labels Jan 6, 2025
@maximebonhomme
Copy link

This is also happening when using the PopupButton

@joycevherck
Copy link
Contributor

@maximebonhomme I'm not able to see the same issue with the PopupButton. Feel free to open a new issue with some more details and I can have a look.

@typeform-ops-gha
Copy link

🎉 This issue has been resolved in version @typeform/embed-v5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants