Have the typescript package perform as much processing of the configuration file as possible. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offload as much of the work as possible to the TypeScript API. By doing things this way, typedoc sees the same configuration as what `tsc` would, and benefits from TypeScript's interpretation of new features in the `tsconfig.json` file. For instance, globs in `include` and `exclude`.
aciccarello
reviewed
Dec 13, 2016
| @@ -1,6 +1,7 @@ | |||
| import * as ts from "typescript"; | |||
| import * as _ts from "../ts-internal"; | |||
| import * as Path from "path"; | |||
| import * as _ from "lodash"; | |||
There was a problem hiding this comment.
Just want to note that this is also a part of #353.
This was referenced Dec 23, 2016
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposed to fix #326. It may also have an impact on some of the other issues in #301.
This is not a complete PR yet but I'd like some help before moving forward. I quickly discovered while working on this that there is currently no test in the test suite that covers the code I changed. (I know because I had some pretty big errors when I copy-pasted into typedoc's codebase the code from the prototype file I created to figure how I'd load a
tsconfig.jsonoutsidetsc. The big errors I had did not cause any test failure!) I'm not sure though what kinds of tests are desired. Should I create anApplication, and check whether it is seeing the right configuration options? Is there a better way to do this?(The first commit in this PR is fixing the same problem as in #353. I need it there, otherwise the code does not compile. I'll remove it once #353 is merged.)