-
-
Notifications
You must be signed in to change notification settings - Fork 536
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid processing
files
from config by default
- Loading branch information
1 parent
f260591
commit 33cb1b5
Showing
2 changed files
with
20 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33cb1b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating to v7 I get errors like this:
This is because the typings are in custom declaration files that are now not anymore auto-loaded. How to solve this?
I would like to avoid triple-slash references or listing out these files on the command line. tsconfig should be the single source of truth
33cb1b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use paths or types. It’s mentioned in the README. This was the change recommended by TypeScript and agreed with it, the fact that your definitions previously worked and don’t now is the reason it was a major release.
33cb1b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it to work after changing
include
totypeRoots
, changing all definitions to be in their own folder, named after the package, and the file being namedindex.d.ts
(anything else wouldn't work).I would be nice if that note to the release notes as a migration hint - when getting automatic update PRs, the release notes are included in the PR so that helps a lot. The next thing I found was this commit, after which I still wasn't sure how to fix it. Thanks for your help.
33cb1b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added https://github.com/TypeStrong/ts-node#help-my-types-are-missing to README and release notes.