Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more detailed error messages #1665

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

hai-x
Copy link
Contributor

@hai-x hai-x commented Jan 10, 2025

Small change and make error messages more detailed.

image

@johnnyreilly
Copy link
Member

Thanks - I think if I understand it correctly, you want to alter the error message? Could you adjust the PR so it only does that please?

@@ -382,7 +382,6 @@ function createWatchFactory(
}
return result;
}
``;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@hai-x
Copy link
Contributor Author

hai-x commented Jan 11, 2025

Thanks - I think if I understand it correctly, you want to alter the error message? Could you adjust the PR so it only does that please?

Ajusted. Could you please review it again?

@johnnyreilly
Copy link
Member

Let's get the GitHub actions running....

@johnnyreilly
Copy link
Member

Please could you update the version in the package.json (patch increment) and put an entry in the CHANGE LOG.md too?

@johnnyreilly
Copy link
Member

You are using thread-loader I'm guessing? What's the motivation?

@hai-x
Copy link
Contributor Author

hai-x commented Jan 11, 2025

Please could you update the version in the package.json (patch increment) and put an entry in the CHANGE LOG.md too?

Sure.

@hai-x
Copy link
Contributor Author

hai-x commented Jan 11, 2025

You are using thread-loader I'm guessing? What's the motivation?

Leverage the power of multi-core in our building system.

@hai-x
Copy link
Contributor Author

hai-x commented Jan 11, 2025

Please could you update the version in the package.json (patch increment) and put an entry in the CHANGE LOG.md too?

Done.

@johnnyreilly johnnyreilly merged commit e652315 into TypeStrong:main Jan 11, 2025
63 checks passed
@johnnyreilly
Copy link
Member

@johnnyreilly
Copy link
Member

Looks like there's a small issue with the release pipeline. Will have to fix that before I can ship the change

@hai-x
Copy link
Contributor Author

hai-x commented Jan 11, 2025

Looks like there's a small issue with the release pipeline. Will have to fix that before I can ship the change

Yes. It seems to be caused by conflict between pnpm version and node version.

@hai-x
Copy link
Contributor Author

hai-x commented Jan 11, 2025

Looks like there's a small issue with the release pipeline. Will have to fix that before I can ship the change

Yes. It seems to be caused by conflict between pnpm version and node version.

I have seen that you have open a related PR. https://github.com/TypeStrong/ts-loader/pull/1666/files

@johnnyreilly
Copy link
Member

Hopefully this will do it: https://github.com/TypeStrong/ts-loader/actions/runs/12726168149/job/35474238704

Will fix up version numbers later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants