-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add more detailed error messages #1665
Conversation
Thanks - I think if I understand it correctly, you want to alter the error message? Could you adjust the PR so it only does that please? |
@@ -382,7 +382,6 @@ function createWatchFactory( | |||
} | |||
return result; | |||
} | |||
``; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another small fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot!
Ajusted. Could you please review it again? |
Let's get the GitHub actions running.... |
Please could you update the version in the package.json (patch increment) and put an entry in the CHANGE LOG.md too? |
You are using thread-loader I'm guessing? What's the motivation? |
Sure. |
Leverage the power of multi-core in our building system. |
Done. |
Thanks! Published with https://github.com/TypeStrong/ts-loader/releases/tag/v9.5.2 |
Looks like there's a small issue with the release pipeline. Will have to fix that before I can ship the change |
Yes. It seems to be caused by conflict between pnpm version and node version. |
I have seen that you have open a related PR. https://github.com/TypeStrong/ts-loader/pull/1666/files |
Hopefully this will do it: https://github.com/TypeStrong/ts-loader/actions/runs/12726168149/job/35474238704 Will fix up version numbers later |
Small change and make error messages more detailed.