Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context option for typescript reporter #430

Merged
merged 1 commit into from
May 28, 2020

Conversation

piotr-oles
Copy link
Collaborator

Add the context option to support the usage of external tsconfig.json files.

Closes: #297

@piotr-oles piotr-oles self-assigned this May 28, 2020
@piotr-oles piotr-oles force-pushed the feature/typescript-context-option branch 2 times, most recently from f364fdf to 44e43f2 Compare May 28, 2020 11:52
@piotr-oles piotr-oles force-pushed the feature/typescript-context-option branch 3 times, most recently from 1f92733 to 1968771 Compare May 28, 2020 14:30
Add `context` option to support usage of external tsconfig.json files.

✅ Closes: #297
@piotr-oles piotr-oles force-pushed the feature/typescript-context-option branch from 1968771 to c146c2a Compare May 28, 2020 18:32
@piotr-oles piotr-oles merged commit a430979 into alpha May 28, 2020
@piotr-oles piotr-oles deleted the feature/typescript-context-option branch May 28, 2020 18:54
@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 5.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shayke
Copy link

shayke commented May 31, 2020

Thanks for the quick fix!

I've tested this and it works great, one thing that is still different, i get:
TS18003: No inputs were found in config file 'tsconfig.json'. Specified 'include' paths were '["**/*"]' and 'exclude' paths were '[]'.

Now, my setup is such that I potentially use webpack without ts files at all (only scss for example).
I understand that tsc -p . on a project with no ts files gives this error but when using ts-loader alone (transpileOnly: false) I don't get such an error and webpack builds successfully.

Any ideas? (other than disabling this plugin if no ts files, I'd rather it silently continue like ts-loader with no errors maybe?).

Thanks!

@piotr-oles
Copy link
Collaborator Author

If you want to skip this error, you can configure it in the plugin:

  new ForkTsCheckerWebpackPlugin({
    issues: {
      exclude: [{ code: 'TS18003' }]
    }
  })

@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 5.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants