[fix] #7, improve error handeling for express errors

Type-Style · Mar 8, 2024 · 67d8ce0 · 67d8ce0
1 parent 24506ac
commit 67d8ce0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/middleware/error.ts b/src/middleware/error.ts
@@ -17,8 +17,11 @@ export function notFound(req: Request, res: Response, next: NextFunction) {
   next(error);
 }
 
-export function handler(err: Error,  req: Request, res: Response<Response.Error>, next: NextFunction) {
-  const statusCode = res.statusCode !== 200 ? res.statusCode : 500;
+export function handler(err: HttpError,  req: Request, res: Response<Response.Error>, next: NextFunction) {
+  let statusCode = res.statusCode;
+  if (statusCode == 200) {
+    statusCode = err.statusCode || err.status || 500
+  }
   res.status(statusCode);
 
   let message;

diff --git a/types.d.ts b/types.d.ts
@@ -1,6 +1,11 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
+interface HttpError extends Error {
+  status?: number;
+  statusCode?: number;
+}
+
 namespace RateLimit {
 	interface obj {
 		[key: string]: {