fix(useWallet): ensure consistent wallet interface across adapters #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor active wallet handling in React and Vue adapters to consistently return `Wallet` interface while preserving `BaseWallet` for transaction signing. Extract `transformToWallet` helper to reduce code duplication. Fix `Wallet` interface to use `WalletId` type instead of string for `id`.
Remove unused `Wallet` interface from Solid adapter since it follows a more idiomatic approach of returning individual reactive properties rather than grouped `Wallet` objects like React and Vue adapters.
Update test mocks to use `BaseWallet` instances instead of `Wallet` objects, matching the actual implementation which returns `BaseWallet` instances in the `wallets` array rather than the framework-specific `Wallet` interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes inconsistencies in how wallet objects are returned across framework adapters. Previously,
activeWalletcould return aBaseWalletwhilewalletsreturnedWallet[], leading to potential type mismatches.Details
activeWalletreturns sameWalletinterface as items inwalletsarraytransformToWallethelper in React/Vue adapters to maintain consistencyBaseWalletinternally for transaction signing onlyWalletinterface to useWalletIdtype instead of stringWalletinterface from Solid adapter (uses individual reactive properties instead)