fix(config): Ignore config files with double dot in it (#696) #984

vlaborie · 2025-01-29T13:39:36Z

Summary

Ignore config files with double dot in it, permit to mount Kubernetes ConfigMap as directory and ignore hidden files like ..date/filename.yaml.

Checklist

Tested and/or added tests to validate that the changes work as intended, if applicable.
Updated documentation in README.md, if applicable.

TwiN · 2025-01-30T00:51:33Z

config/config.go

@@ -176,6 +176,10 @@ func LoadConfiguration(configPath string) (*Config, error) {
 			if err != nil {
 				return fmt.Errorf("error walking path %s: %w", path, err)
 			}
+			if strings.Contains(path, "..") {
+				logr.Warnf("[config.LoadConfiguration] Ignore configuration from %s", path)


Can you update the log message to say "Ignoring" instead of ignore? (I'm on mobile and my laptop is currently out for repair, I'd have made the change myself otherwise)

I have update the message

TwiN requested changes Jan 30, 2025

View reviewed changes

fix(config): Ignore config files with double dot in it (TwiN#696)

7601c6f

vlaborie force-pushed the master branch from 20c2442 to 7601c6f Compare January 30, 2025 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(config): Ignore config files with double dot in it (#696) #984

fix(config): Ignore config files with double dot in it (#696) #984

vlaborie commented Jan 29, 2025

TwiN Jan 30, 2025

vlaborie Jan 30, 2025

fix(config): Ignore config files with double dot in it (#696) #984

Are you sure you want to change the base?

fix(config): Ignore config files with double dot in it (#696) #984

Conversation

vlaborie commented Jan 29, 2025

Summary

Checklist

TwiN Jan 30, 2025

Choose a reason for hiding this comment

vlaborie Jan 30, 2025

Choose a reason for hiding this comment