-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maintenance): Per-endpoint maintenance configuration #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5ca32b
to
174eea9
Compare
Looking forward to this feature getting merged. |
@Kemichal if you wanted to test it in the meantime, you can pull from:
Those are built from my |
TwiN
approved these changes
Feb 17, 2025
@alexmaras Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently working well on my locally running instance.
Summary
Adds maintenance windows per endpoint, with the ability for multiple maintenance windows (array of maps)
Fixes #312
Checklist
README.md
, if applicable.Let me know if any more testing makes sense. The base maintenance testing (i.e.
IsUnderMaintenance()
) is already covered by the Maintenance testing in general, this only adds a new check in thewatchdog
to handle those.