Fix for issue 903 #910
Merged
Fix for issue 903 #910
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xukai92
approved these changes
Sep 15, 2019
xukai92
reviewed
Sep 15, 2019
| @@ -146,7 +146,7 @@ function assume(spl::Sampler{<:MH}, dist::Distribution, vn::VarName, vi::VarInfo | |||
| spl.state.proposal_ratio -= log(cdf(stdG, (ub-r)/σ) - cdf(stdG,(lb-r)/σ)) | |||
| else # Other than Gaussian proposal | |||
| r = rand(proposal) | |||
| if (r < support(dist).lb) | (r > support(dist).ub) # check if value lies in support | |||
| if !(insupport(dist, r)) # check if value lies in support | |||
There was a problem hiding this comment.
Thanks for the fix. Looks correct to me. Can we introduce a test for this fix?
Maybe we can extract the code within the if-statmeent if typeof(proposal) == Distributions.Normal{Float64} into a function and perform the "if-else" via multiple dispatch. And by doing we can implement some tests easily too.
There was a problem hiding this comment.
It's not quite clear what we want to test 🤔 Sort, what is your @test the_function(args...) == ?
There was a problem hiding this comment.
It's probably ok to do the refactoring @xukai92 suggested in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #906 (comment)