Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Combinatorics at version 1 for package test, (keep existing compat) #2448

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request sets the compat entry for the Combinatorics package to 1 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@penelopeysm penelopeysm force-pushed the compathelper/new_version/2024-12-20-00-32-40-174-02134083081 branch from 2b2864a to 5c42086 Compare December 20, 2024 00:32
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (25d2023) to head (5c42086).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2448   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files          21       21           
  Lines        1588     1588           
=======================================
  Hits         1356     1356           
  Misses        232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12423194335

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.865%

Totals Coverage Status
Change from base Build 12411420069: 0.0%
Covered Lines: 1216
Relevant Lines: 1582

💛 - Coveralls

@yebai yebai merged commit 2b8d509 into master Dec 20, 2024
59 of 62 checks passed
@yebai yebai deleted the compathelper/new_version/2024-12-20-00-32-40-174-02134083081 branch December 20, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants