Fix MH indexing bug #1135
Merged
Fix MH indexing bug #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this can be handled in a completely "nice" way at the moment. Maybe something along the lines of TuringLang/DynamicPPL.jl#5 would be helpful. |
|
Looks like the test failures are due to nondeterminism in the VI suite. I'll open a separate PR to fix the test. |
|
I think this can go through, at the very least to fix #1133. If the comments in TuringLang/DynamicPPL.jl#5 are addressed, I can come back to the general approach that AdvancedMH uses to integrate into Turing. |
|
Maybe add a test for the error case? |
|
Updated to include the test for the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1133 by fixing a case where the Turing-side code was not passing scalars correctly to AdvancedMH.
Currently the way I handle passing NamedTuples into Turing is not very robust (and could be more performant), so I'm doubly open to comments on this one.
set_namedtuple!for example is a very messy and ugly function that relies far too much on heuristics.