Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #46

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Fix docs #46

merged 1 commit into from
Sep 22, 2021

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Sep 22, 2021

One has to set the deployed branch explicitly if it is not called master. I also removed some things that seemed unnecessary and added stricter checks for missing documentation (it will error if not everything is documented that is exported; in this case I'll comment it for now but it would be good to fix it).

I assume it fixes #45

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #46 (3bcceac) into main (425404f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files          11       11           
  Lines         328      328           
=======================================
  Hits          279      279           
  Misses         49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425404f...3bcceac. Read the comment docs.

Copy link
Member

@cpfiffer cpfiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one way to find out if it fixes it!

@devmotion
Copy link
Member Author

I think the error is JuliaDocs/Documenter.jl#1693, so I'll merge and hopefully this fixes it 🙂

@devmotion devmotion merged commit c59fe08 into main Sep 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the dw/docs branch September 22, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs are failing to generate
2 participants