-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README, add section on parallel and distributed sampling #109
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 16 16
Lines 1673 1673
=======================================
Hits 1195 1195
Misses 478 478 ☔ View full report in Codecov by Sentry. |
Let's add this information to the docs instead of README. We also want to transfer other README materials to docs gradually. Can you also add a test for parallel and distributed sampling? This |
Of course, adding to doc is better. Thanks for the link also. |
src/new_passes.jl
Outdated
|
||
function ForExpr(expr) | ||
processed_expr = only(loop_fission_helper(expr)) | ||
T = Union{Int, Symbol, Expr} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
T = Union{Int, Symbol, Expr} | |
T = Union{Int,Symbol,Expr} |
src/new_passes.jl
Outdated
end | ||
end | ||
sub_expr | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
end | |
end |
src/new_passes.jl
Outdated
for (i, id) in enumerate(idx) | ||
if id isa Number # good | ||
elseif id isa Symbol | ||
id = le.loop_bounds[findfirst(x->x==id, le.loop_vars)][2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
id = le.loop_bounds[findfirst(x->x==id, le.loop_vars)][2] | |
id = le.loop_bounds[findfirst(x -> x == id, le.loop_vars)][2] |
src/new_passes.jl
Outdated
if MacroTools.@capture(se, l_:h_) | ||
h | ||
elseif se in le.loop_vars | ||
le.loop_bounds[findfirst(x->x==se, le.loop_vars)][2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
le.loop_bounds[findfirst(x->x==se, le.loop_vars)][2] | |
le.loop_bounds[findfirst(x -> x == se, le.loop_vars)][2] |
src/new_passes.jl
Outdated
test_e = @bugs begin | ||
for i in 1:N | ||
for j in 1:M | ||
Y[i:i+1, j:j+1] ~ Normal(mu[i, j], sigma) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
Y[i:i+1, j:j+1] ~ Normal(mu[i, j], sigma) | |
Y[i:(i + 1), j:(j + 1)] ~ Normal(mu[i, j], sigma) |
test/bugsast.jl
Outdated
@test repr(JuliaBUGS.sort_expressions(expr)) == | ||
repr(@bugs begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
@test repr(JuliaBUGS.sort_expressions(expr)) == | |
repr(@bugs begin | |
@test repr(JuliaBUGS.sort_expressions(expr)) == repr(@bugs begin |
test/bugsast.jl
Outdated
for i = 1:N | ||
for j = 1:T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
for i = 1:N | |
for j = 1:T | |
for i in 1:N | |
for j in 1:T |
test/bugsast.jl
Outdated
for i = 1:N | ||
for j = 1:T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
for i = 1:N | |
for j = 1:T | |
for i in 1:N | |
for j in 1:T |
test/bugsast.jl
Outdated
end | ||
end | ||
|
||
for i = 1:N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
for i = 1:N | |
for i in 1:N |
test/bugsast.jl
Outdated
alpha[i] ~ dnorm(var"alpha.c", var"alpha.tau") | ||
end | ||
|
||
for i = 1:N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
for i = 1:N | |
for i in 1:N |
a334e63
to
7b9c54c
Compare
Fix #70