-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Small simplification of compiler #221
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3baa9f6
removed unnecessary in args check
torfjelde 823e751
drop carrying args around
torfjelde 2efdc66
Merge branch 'master' into tor/compiler-simplification
torfjelde e29ef2e
Update src/compiler.jl
torfjelde 8aefe12
using Val to improve efficiency
torfjelde b993af0
expand isassumption as before
torfjelde 6925db7
reverted changes to isassumption since @devmotion upgraded AbstractPPL
torfjelde 67dfd63
Merge branch 'master' into tor/compiler-simplification
torfjelde 726fca7
Run Turing integration test with Julia 1.5
devmotion 6f6bf55
Merge branch 'master' into dw/integration
devmotion f2c180d
Merge branch 'dw/integration' into tor/compiler-simplification
torfjelde 9eae757
Update src/varname.jl
torfjelde 529d800
Update Project.toml
torfjelde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW (I know not part of this PR 🙂): Why do we actually assign the output of
isassumption
to a variable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh haha, I read
do we actually assign the output of isassumption to a variable?
, didn't see thewhy
.It's because
isassumption
generates a larger if-statement which returns aBool
, so we can't e.g. doif $(DynamicPPL.isassumption(left))
.