Bugs in the docs for the nonlinear example

[mattiasvillani]

The changes in PR #79 led to the following bugs (some edits in #79 following the review strangely got lost in the final version):

• The title got removed from the example doc
• Long printout of not important vector
• The replay of the trajectories somehow got killed in edits following the PR preview which led the pgas trajectories not showing in the plot.
• The rng argument that was requested to be added to the pgas call also got wiped out in the edits from the review.

This PR fixes all four issues.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (72a1e55) 96.32% compared to head (138b4c6) 96.32%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files           7        7           
  Lines         381      381           
=======================================
  Hits          367      367           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FredericWantiez]

This should have been (without using the suggestion tool, since I messed up everything last time):

particles = hcat([trajectory.model.f.X for trajectory in chains]...); # pulling it from the chains directly

and you should be able to remove the replay part

[mattiasvillani]

I would need to read up on the replay idea here, but replacing

trajectories = map(chains) do sample replay(sample.trajectory) end particles = hcat([trajectory.model.f.X for trajectory in trajectories]...);

with

particles = hcat([trajectory.model.f.X for trajectory in chains]...); # pulling it from the chains directly

gives me the error:

ERROR: type PGSample has no field model

[FredericWantiez]

This fixes this issue

particles = hcat([chain.trajectory.model.X for chain in pgas_chains]...)

but seems to hit another one with the way we copy models around. I'll open an issue and look into it

[mattiasvillani]

Maybe we can keep the (possibly redundant) replay part for now and merge my PR? That would be better than the severely broken version merged at the moment.

[FredericWantiez]

Agree, since the fix pretty much requires #75 to be merged first

[yebai]

Thanks @mattiasvillani and @FredericWantiez!