Add CI tests and CompatHelper #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage ? 81.03%
=======================================
Files ? 1
Lines ? 58
Branches ? 0
=======================================
Hits ? 47
Misses ? 11
Partials ? 0 Continue to review full report at Codecov.
|
|
LGTM as far as I can judge, but I'm not really familiar with GitHub workflows. I have added the deploy key, can you check if it works correctly? |
|
Unfortunately, I don't think it's possible to check it - we have to wait until CompatHelper runs or trigger it manually once the action is available in the default branch. |
bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2022
This is a draft PR introducing a `Model` type that stores and makes use the model graph.
The main type introduced here is the `Model` struct which stores the `ModelState` and `DAG`, each of which are their own types. `ModelState` contains information about the node values, dependencies and eval functions and `DAG` contains the graph and topologically ordered vertex list.
A model can be constructed in the following way:
```julia
julia> nt = (
s2 = (0.0, (), () -> InverseGamma(2.0,3.0), :Stochastic),
μ = (1.0, (), () -> 1.0, :Logical),
y = (0.0, (:μ, :s2), (μ, s2) -> MvNormal(μ, sqrt(s2)), :Stochastic)
)
(s2 = (0.0, (), var"#33#36"(), :Stochastic), μ = (1.0, (), var"#34#37"(), :Logical), y = (0.0, (:μ, :s2), var"#35#38"(), :Stochastic))
julia> Model(nt)
Nodes:
μ = (value = 1.0, input = (), eval = var"#16#19"(), kind = :Logical)
s2 = (value = 0.0, input = (), eval = var"#15#18"(), kind = :Stochastic)
y = (value = 0.0, input = (:μ, :s2), eval = var"#17#20"(), kind = :Stochastic)
DAG:
3×3 SparseMatrixCSC{Float64, Int64} with 2 stored entries:
⋅ ⋅ ⋅
⋅ ⋅ ⋅
1.0 1.0 ⋅
```
At present, only functions needed for the constructors are implemented, as well as indexing using `@varname`. I still need to complete the integration with the AbstractPPL api. TODO:
~~- [ ] `condition`/`decondition`,~~
~~- [ ] `sample`~~
~~- [ ] `logdensityof`~~
- [x] pure functions for ordered dictionary, as outlined in [AbstractPPL](https://github.com/TuringLang/AbstractPPL.jl#property-interface)
Feedback on `Model` structure welcome whilst I implement the remaining features!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to this PR, one has to add a SSH deploy key (e.g., by following the instructions here: https://github.com/JuliaRegistries/CompatHelper.jl#122-instructions-for-setting-up-the-ssh-deploy-key) to allow CompatHelper to trigger the CI tests.