Improved/fixed @turf/buffer using equidistant buffers #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Project coordinates to TransverseMercator centered on GeoJSON to performe distance buffer in meters - Added a few more input validation - Dropped `@turf/dissolve` since jsts was faster with multiPoint - Add Geometry Object tests - Add prevent input mutation tests
Is fixed in next minor release
This was referenced May 7, 2017
|
Looks like a big improvement @DenisCarriere , nice one! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Buffers were being distorted the further away it was from [0, 0]. Distances from north to south were different than west to east when measuring the output buffer. The expected output of a buffer should have its geometry equidistance in all directions.
Summary
jstsbuffer calculation, unproject coordinates (to degrees) for final output.@turf/dissolvesincejstswas faster with multiPointmoscow-ringsas inspiration.Ref: #660 #88
CC: @flightsurvey @bjornharrtell @rowanwins
Before
After
Equidistance Polygon Buffer