Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citadel with the latest commits. Need further review #147

Open
wants to merge 206 commits into
base: citadel_support
Choose a base branch
from

Conversation

TrezorHannes
Copy link
Collaborator

No description provided.

@TrezorHannes TrezorHannes self-assigned this Nov 15, 2024
Increase Data Cleanup from 10 min to 1 hour.
@blckbx
Copy link
Collaborator

blckbx commented Nov 15, 2024

Proposal: Instead of resolving various confilcts by merging main branch into citadel branch, we should rather extract citadel specific install and uninstall instructions into new bash scripts and merge them into main. wdyt?

@TrezorHannes
Copy link
Collaborator Author

Proposal: Instead of resolving various confilcts by merging main branch into citadel branch, we should rather extract citadel specific install and uninstall instructions into new bash scripts and merge them into main. wdyt?

So like a separare setupv2_citadel.sh?
Gives me a notion that we should probably think about it for all major systems.

  • a starting script with the OS choice
  • calling nested sub-scripts based on the choice

Benefit would be mostly readability. We could try build this for citadel only (one main, one sub-file) and see how that works.

What do you think?

TrezorHannes and others added 3 commits January 28, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants