Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedicated diff for components.params #354

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Aug 2, 2023

The bug was caused because we used ParametersDiff to compare params under components.
I renamed ParametersDiff to ParametersDiffByLocation and created a new type, ParametersDiff, to compare params under components without considering the param location (query, path, header or cookie).
Also added an "InDiff" field to ParameterDiff to cover the use case that a parameter under components could be modified by changing its location.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #354 (3420a62) into main (3a7f646) will decrease coverage by 0.15%.
The diff coverage is 88.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   80.55%   80.41%   -0.15%     
==========================================
  Files         191      191              
  Lines       10033    10083      +50     
==========================================
+ Hits         8082     8108      +26     
- Misses       1641     1659      +18     
- Partials      310      316       +6     
Flag Coverage Δ
unittests 80.41% <88.77%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
checker/checker.go 42.43% <0.00%> (ø)
diff/parameters_diff_by_location.go 74.80% <86.66%> (ø)
diff/parametes_diff.go 89.83% <89.83%> (ø)
diff/components_diff.go 94.44% <100.00%> (ø)
diff/headers_diff.go 95.23% <100.00%> (ø)
diff/method_diff.go 85.93% <100.00%> (ø)
diff/parameter_diff.go 72.72% <100.00%> (+0.50%) ⬆️
diff/path_diff.go 88.46% <100.00%> (ø)
report/report.go 75.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@reuvenharrison reuvenharrison merged commit f40f595 into main Aug 2, 2023
@reuvenharrison reuvenharrison deleted the 352-2x-same-param-name-in-componentsparameters-triggers-diff-for-identical-base-and-revision branch August 2, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2x same param name in components.parameters triggers diff for identical base and revision
2 participants