🎨 run database population in transaction #7448
Merged
+48
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: right now i am writing down a migration spec. I will update add the reference to the Github issue later. |
|
Note: merge into |
ErisDS
reviewed
Sep 29, 2016
| transaction.rollback(); | ||
| }); | ||
| }).catch(function populateDatabaseError() { | ||
| reject(); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
refs TryGhost#6574, refs TryGhost#7432 - create transaction for creating tables - if an error occurs or a container get's destroyed before population finishes, transaction is rolled back
kirrg001
force-pushed
the
fix/populate-database-in-transaction
branch
from
eac4d78 to
3ecce35
Compare
ErisDS
requested changes
Sep 30, 2016
| }); | ||
| }).catch(function populateDatabaseError(err) { | ||
| reject(err); | ||
| }); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| return new Promise.resolve(); | ||
| }); | ||
|
|
||
| transactionStub = sandbox.stub(db.knex, 'transaction', function (transactionStart) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -56,7 +56,7 @@ createOwner = function createOwner(logger, modelOptions) { | |||
| password: coreUtils.uid(50) | |||
| }; | |||
|
|
|||
| return models.Role.findOne({name: 'Owner'}).then(function (ownerRole) { | |||
| return models.Role.findOne({name: 'Owner'}, modelOptions).then(function (ownerRole) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
See second commit, i kept it so you can look at it 👍 |
ErisDS
approved these changes
Sep 30, 2016
|
This looks 100% awesome to me 👍 |
|
Have cherrypicked this directly onto the lts branch as it is a clean merge. |
22 tasks
4 tasks
yo1dog
pushed a commit
to yo1dog/Ghost
that referenced
this pull request
Oct 14, 2016
* 🎨 run database population in transaction refs TryGhost#6574, refs TryGhost#7432 - create transaction for creating tables - if an error occurs or a container get's destroyed before population finishes, transaction is rolled back * 🎨 simplify transaction creation and test
mixonic
pushed a commit
to mixonic/Ghost
that referenced
this pull request
Oct 28, 2016
* 🎨 run database population in transaction refs TryGhost#6574, refs TryGhost#7432 - create transaction for creating tables - if an error occurs or a container get's destroyed before population finishes, transaction is rolled back * 🎨 simplify transaction creation and test
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
* 🎨 run database population in transaction refs TryGhost#6574, refs TryGhost#7432 - create transaction for creating tables - if an error occurs or a container get's destroyed before population finishes, transaction is rolled back * 🎨 simplify transaction creation and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6574, refs #7432
Populate database in a transaction.
We had issues in the past, that if a Ghost container get's destroyed before the population could finish, the database was left in a corrupt state.