Data & fixture migration cleanup #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#6621, TryGhost#6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some unnecessary code, improves quality of some of the tests, gets the coverage back to 100% and trims down the amount of code in the tests. There's also a change to the jQuery fixture update to make it consistent with the other settings fixture updates.
It's basically an odd collection of stuff I noticed whilst working on 005 migrations.
refs #6621, #6622
return new Promise.resolve()lines