Data 005 - Part 1 - Fix Past Fixtures (refactor & test fixture migrations) #6572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
ErisDS
force-pushed
the
data005-part1-fixpastfixtures
branch
from
6daef12 to
b2659d0
Compare
ErisDS
changed the title
sebgie
added a commit
that referenced
this pull request
Mar 7, 2016
Data 005 - Part 1 - Fix Past Fixtures (refactor & test fixture migrations)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 8 commits here, which should be squashed before merging.
Here's a rough outline of what I have done:
Fixtures:
Permissions fixtures:
permissions.jsonfile.Merging the two things:
The result is significantly less code for handling fixture updates and population, and significantly more tests.
Current test coverage on master 😞 :
Test coverage with this PR 🎉 :