🚧 Implemented plugin based author model in API v2

[naz]

refs #10124

• Author model returns only users that have published posts

This is just a first go with Authors API v2 endpoint only. More to come tomorrow once this approach is discussed :)

[kirrg001]

Code looks good in general 👍

Just leaving some thoughts:

• i think we have to clarify the sitemap service before shipping any of this change? if we don't return authors without posts, then these authors will 404 for v2, but sitemap service will still show the urls
• group model representations of existing models in a sub folder?

[naz]

group model representations of existing models in a subfolder?

This is a good question. For now, there is just one/two models, so maybe too early of an optimization, but definitely would go with something to separate models that just extend existing ones.

[naz]

Notes from a discussion we had with @kirrg001 about further approach:

1. Introduce 2nd config for resources - we will maintain 2 configs apiV01 and apiV2 as there's no better approach to separate logic at the moment
2. Call 'hasPosts' plugin straight from knex during UrlService initialization
3. Double check if cold boot happens when theme provided ghost-api value changes (logic similar to releaseResourcesOnly)
4. Do a UrlService data reset only when the version is changed
5. Add a comment in the codebase about long-term plan behind resource

[kirrg001]

This approach does not work with the get helper.

e.g. {{#get "tags"}}

It will query the tags controller and not the tags-public controller.

[kirrg001]

It will query the tags controller and not the tags-public controller.

You probably just need to tweak the get helper.
If we solve #10106, it will be easier to handle this.

[kirrg001]

@gargol Could you please rebase against master? Thanks 😃

[naz]

Corrected the {{get "tags"}} helper but still running into a situation when there's no data populated in UrlService after the theme is switched, will need to investigate this problem a bit deeper.

[kirrg001]

Found two more bugs:

1

• v2 is enabled
• i have 0 tags listed on the sitemap, because none of my posts have tags
• now i add a tag to a post
• sitemaps are not being refreshed
• same appears for when i remove a tag from a post and the tag is not assigned to any post

I assume this not trivial to solve, because we will receive the url event for the post, but we don't have a trigger that the tag url is now available.

2

If i have a tag which is not assigned to any post, i won't receive the tag via the content API, but i can serve the tag on the site.

To reproduce:

• create a tag
• assign this tag to no posts (tag has no posts)
• http://localhost:2368/ghost/api/v2/content/tags/?key=lol won't expose this tag
• serve /tag/xxxx

If you do the same with an author. It works for both cases.

[kirrg001]

I will look into (2) now. I will also rebase the branch against master.

[naz]

Merging it as is for now 🚀 Will follow up with an issue that should address 2 problems discovered by QA