Fix(migrations): allow existing content/settings folder #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikaspotluri123
changed the title
|
Gonna go ahead and rebase this against the master branch - it's separate from the ghost 2.0 work so I think it's worth it to keep the eventual 1.9 PR a bit smaller :) |
|
....and that promptly broke things lol. @vikaspotluri123 would you mind rebasing this branch against master? |
issue TryGhost#776 In production sites, when the ghost user is used, the `content/*` folder needs to be owned by the Ghost user so the ghost application will not run into permission issues. In the migration, to make sure this happens, we run the `mkdir` command using sudo (i.e. `sudo -E -u ghost mkdir {path}`). When the Ghost user isn't needed, we use the `fs-extra` library to make sure the directory exists (specifically `ensureDirSync`). `fs.ensureDirSync` is equivilant to running `mkdir` with the `p` flag, so the behaviour between sudo and no-sudo differs. By adding the `p` flag to the sudo command, the behaviour between the two cases are equalized, and the migrations won't fail if the content/settings folder exists when the Ghost user is used.
vikaspotluri123
force-pushed
the
fix/settings-folder-sudo-permission
branch
from
b5cd11d to
7634ef0
Compare
|
Done! |
acburdine
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #776
In production sites, when the ghost user is used, the content/* folder needs to be owned by the Ghost user so the ghost application will not run into permission issues. In the migration, to make sure this happens, we run the
mkdircommand using sudo (i.e.sudo -E -u ghost mkdir {path}). When the Ghost user isn't needed, we use thefs-extralibrary to make sure the directory exists (specificallyensureDirSync).fs.ensureDirSyncis equivilant tomkdir -p(notmkdir), so the behaviour differs. By adding thepflag to themkdircommand that's run when the Ghost user is used, the behaviour between the two cases are equalized, including support for a settings folder that already exists