Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): fix start/no-start option #684

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

acburdine
Copy link
Member

closes #615

  • respect no-start in local installs
  • fix ui.confirm usage

closes TryGhost#615
- respect no-start in local installs
- fix ui.confirm usage
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 837f6fa on acburdine:fix/local-start into 6ccf6be on TryGhost:master.

@vikaspotluri123
Copy link
Member

What were the changes w/ ui.confirm?

Copy link
Member

@vikaspotluri123 vikaspotluri123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested w/ --no-start, --no-start --no-prompt and --no-prompt

@acburdine
Copy link
Member Author

@vikaspotluri123 so instead of passing back an object with {yes: ) the ui.confirm option was updated to return just a straight boolean - made some things simpler. Missed this particular bit of code initially though when I went in and changed the method :)

@acburdine acburdine merged commit 46d64f8 into TryGhost:master Mar 26, 2018
@acburdine acburdine deleted the fix/local-start branch March 26, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--no-start flag gets ignored when running ghost install local
3 participants