Ensure content/settings folder
#681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2018
|
It would be good to ship this asap. When is the next release planned? And if we have released this, we can then release TryGhost/Ghost#9534 with a new CLI engine bump in Ghost. Currently we throw
Would be great to extend this error a bit and tell the user what todo cc @AileenCGN. |
|
@AileenCGN Why is this on HOLD?
No.
|
aileen
changed the title
content/settings foldercontent/settings folder
aileen
force-pushed
the
feat/content-settings
branch
from
bd0a232 to
4d248e7
Compare
acburdine
approved these changes
Apr 10, 2018
aileen
force-pushed
the
feat/content-settings
branch
from
4d248e7 to
9788651
Compare
|
@acburdine Version is now set to 1.7.0 |
|
Works - thanks @AileenCGN 😄 |
aileen
added a commit
to aileen/Ghost-CLI
that referenced
this pull request
Apr 11, 2018
refs TryGhost#681 refs TryGhost#587 Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
aileen
added a commit
to aileen/Ghost-CLI
that referenced
this pull request
Apr 11, 2018
refs TryGhost#681 refs TryGhost#587 Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
kirrg001
pushed a commit
that referenced
this pull request
Apr 11, 2018
aileen
added a commit
to aileen/Ghost
that referenced
this pull request
Apr 14, 2018
refs TryGhost#9528 refs TryGhost/Ghost-CLI#681 - added a new `/content/settings` folder - bumped Ghost-CLI engine requirement to >= 1.7.0
kirrg001
pushed a commit
to TryGhost/Ghost
that referenced
this pull request
Apr 15, 2018
refs #9528 refs TryGhost/Ghost-CLI#681 - added a new `/content/settings` folder - bumped Ghost-CLI engine requirement to >= 1.7.0
vikaspotluri123
pushed a commit
to vikaspotluri123/Ghost-CLI
that referenced
this pull request
Apr 25, 2018
…ost#702) refs TryGhost#681 refs TryGhost#587 Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#9528
content/settingsfolder to install process (for new installations)content/settingsexists (for older installations)Todos:
create defaultroutes.yamlfile on install and migration. Question: where to get the default values from?