fix(local-process): error if content folder owned by other user #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/utils/local-process.js
Outdated
| const stat = fs.lstatSync(path.join(cwd, 'content')); | ||
|
|
||
| // Check that content folder is owned by the current user | ||
| if (stat.uid !== process.getuid()) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
acburdine
force-pushed
the
fix/local-process
branch
from
f2505db to
2fe6443
Compare
kirrg001
reviewed
Feb 3, 2018
lib/utils/local-process.js
Outdated
| @@ -151,6 +168,15 @@ class LocalProcess extends ProcessManager { | |||
| return running; | |||
| } | |||
|
|
|||
| _checkContentFolder(cwd) { | |||
| if (os.platform() !== 'linux') { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
closes TryGhost#501 - if the content folder is owned by a separate user, the local process manager will fail - improve local process manager errors - add local process manager tests
acburdine
force-pushed
the
fix/local-process
branch
from
2fe6443 to
d490297
Compare
kirrg001
approved these changes
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #501