Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): add systemd process manager tests #544

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

vikaspotluri123
Copy link
Member

I feel like there's some repetition, so if you have any suggestions, feel free to comment!

ref: #541

@coveralls
Copy link

Coverage Status

Coverage increased (+2.09%) to 86.868% when pulling e563ab4 on vikaspotluri123:systemd-tests into 7b93571 on TryGhost:master.

@vikaspotluri123 vikaspotluri123 mentioned this pull request Nov 17, 2017
30 tasks
@acburdine
Copy link
Member

Nah, I don't think it's too bad. We could abstract those tests out, but then we'd have to split them out in the future if/when we ever change the behavior of one function.

@vikaspotluri123 vikaspotluri123 changed the title chore(tests) Add Systemd Process Manager tests chore(tests): add systemd process manager tests Nov 17, 2017
Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@acburdine acburdine merged commit 2a14688 into TryGhost:master Nov 18, 2017
@vikaspotluri123 vikaspotluri123 deleted the systemd-tests branch November 18, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants